Remove the test directory from ignore in bower.json #50
Conversation
|
q: Why do users need the test/ dir when consuming this element? |
|
It's to facilitate @azakus's https://github.com/polymerelements/test-all setup. |
|
The only reason I ask, is because the repercussions to all consumers of this (who vendor bower_components or download) can be quite large. I wonder if test-all might want to use a different approach like Thoughts? 🌴 |
|
@samccone I raised this issue mostly out of consistency. All of the other elements let their tests exist with bower install. This makes it very easy to use the existing infrastucture of the CI runner to test eveything. If we were to remove all the tests from bower distribution, I would have to specially craft something for test-all and/or the CI Runner to run the tests. This isn't too bad, but I'd like to do it only if necessary. The less things that CI Runner has to do, the better and safer it is. |
|
@jeffposnick can we get this rebased? |
|
The conflicts are resolved. |
|
To help enable the goal of consistency with other repos (and I really want to see the CI Runner working smoothly here), I'm going to go ahead and merge this. If we decide to change strategies later down the line this is easily ameliorated. |
Remove the test directory from ignore in bower.json
|
word 👍 makes sense @addyosmani just throwing out some thoughts |
|
I'm happy to do this for now. If Bower didn't actually have to download the things in the ignore list then I would say we should try to find a work around to speed up install for everyone. But since Bower downloads everything and then just deletes the stuff in the ignore, it doesn't make a lot of difference ATM. |
|
👍 only for the people that vendor everything without an eager .gitignore |
R: @wibblymat @azakus
We'd want to tag a 1.0.3 release after merging this.