Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(package): scripts don't require "--" for options to be forwarded #4437

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

paulirish
Copy link
Member

This isn't required in Yarn 1.0+ or NPM.

And now we kill off this warning:
image

@wardpeet
Copy link
Collaborator

wardpeet commented Feb 6, 2018

i'm pretty sure npm still needs it but we aren't using it in our scripts so we can just ship this

$ npm start http://m.nieuwsblad.be/ --view
> lighthouse@2.8.0 start /mnt/c/Users/WardPeeters/Projects/os/lighthouse
> node ./lighthouse-cli/index.js "http://m.nieuwsblad.be/"

$ npm start http://m.nieuwsblad.be/ -- --view

> lighthouse@2.8.0 start /mnt/c/Users/WardPeeters/Projects/os/lighthouse
> node ./lighthouse-cli/index.js "http://m.nieuwsblad.be/" "--view"

Copy link
Collaborator

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@patrickhulce patrickhulce merged commit 1b96506 into master Feb 6, 2018
@patrickhulce patrickhulce deleted the doubledash branch February 6, 2018 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants