Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(smokehouse): improve smokehouse failure output #4482

Merged
merged 1 commit into from
Feb 9, 2018
Merged

tests(smokehouse): improve smokehouse failure output #4482

merged 1 commit into from
Feb 9, 2018

Conversation

paulirish
Copy link
Member

Based on recently having to poke around the output, here's a proposal to improve the readability of failures.

Two before & after examples, taken from recent failures:

image

image

changes

  • display expected & found on top of eachother
  • switch order so found comes next to "full found result"
  • serialize objects, including regular expressions. no more [Object object]
  • formatting

patrickhulce
patrickhulce approved these changes Feb 8, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrickhulce patrickhulce merged commit d8daeb3 into master Feb 9, 2018
@patrickhulce patrickhulce deleted the smokehouseoutput branch February 9, 2018 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulirish @patrickhulce @devtools-bot