-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report: celebrate your all 100's #5455
Conversation
.score100 .lh-lighthouse {
animation: 4s linear infinite party-lighthouse;
}
@keyframes party-lighthouse {
from{
filter: hue-rotate(0deg);
}
to{
filter: hue-rotate(360deg);
}
} |
Ha, this is awesome!!! ❤️ |
@hwikyounglee and I were just thinking it might be cool to go all out and replace the dark gray background and do a animation through the rainbow :D .score100 .lh-header-bg {
background: #f00;
animation: 4s linear infinite party-background;
}
@keyframes party-background {
from{
filter: hue-rotate(0deg);
}
to{
filter: hue-rotate(360deg);
}
} |
A suggestion to the excitement: shall we have a way to stop the animation to provide a control? |
see commits for changes |
My vote is for lights coming out of he ligthouse as if there’s an epic party going on inside 👏 |
Lighthouse blue!? It's safer to sail in the day time. Also noticed a few scroll bugs. Background area shows through header: Is the share icon meant to be see through? As @hwikyounglee pointed this out too. The text is hard to see: |
examples are updated: |
Took @JoelEinbinder's amazing party CSS and applied it to just the lighthouse light: |
oh VERY yes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for bringing this back to life, @exterkamp
one nit, but this LGTM.
const scoreScale = this._dom.find('.lh-scorescale', scoresContainer); | ||
scoreScale.style.opacity = `${1 - scrollPct}`; | ||
scoreScale.style.transform = `translateY(${scrollPct * -scoreScalePositionDelta}px)`; | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need this try/catch any longer.. pretty sure it was resolved somewhere else.. but IIRC it only applied in the single-category case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets just move a few lines inside of a
const scoreScale = this._dom.find('.lh-scorescale', scoresContainer);
if (scoreScale) { ... }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error is on the find itself. This still throws, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what i meant to say is.. "what a beautiful try/catch! let's keep it just like it is."
Updated examples: |
Super fun I want this yesterday. just gonna bring up @hwikyounglee's concerns about how this could be distracting.
WDYT of stopping when clicking? (or better, some text somewhere saying This is under the assumption that a report of 100s still has useful information that developers might spent non trivial amounts of time reviewing the report. |
Personally, I dont think it's worth adding user control to stop the animation. But Shane already did it so whatever. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, agree about the interaction controls being unnecessary. Seeing the animation without cheating is going to be incredible rare in the first place, and you wouldn't have that report open for that long anyways because there's nothing much to look at in a perfect report but this new thing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dig it.
🎆 🎆 🎆 🎆 🎆 🎆 🎆 🎆 🎆 🎆 🎆 🎆 🎆 🎆 🎆 🎆 🎆 🎆 🎆 🎆 |
It's come up before. But it came up today: https://twitter.com/RobertJGabriel/status/1004604294102945793
The logic is, reward within the report if all the categories in your report have a 100. This can trigger even if you're only testing a single category. I considered enforcing that 2 or more categories are present, but that seems arbitrary.
(A further thing to explore: add additional fireworks per each included category. From a trickle up to a finale.)
example report: