new_audit: add a11y manual audit for interactive element affordance #5764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelhsmith
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
|
lgtm |
paulirish
requested changes
Aug 1, 2018
…sample-json to update sample_v2.json again
paulirish
approved these changes
Aug 2, 2018
|
thanks @joelhsmith this is great. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new a11y manual audit for interactive element affordance
New feature
Forgetting to provide affordances for links and buttons is a common web accessibility issue that is often overlooked because it is a manual check. In preparation for adding this audit, I already added corresponding documentation to the Google Web Fundamentals "How To Do an Accessibility Review" page. google/WebFundamentals#6384
Related Issues/PRs
#5667