audit(preconnect, preload): dont show zero ms savings #5983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Sep 7, 2018
There was a problem hiding this comment.
ya this is consistent with redirects and render-blocking-resources audits. sg.
@brendankenny you had thoughts tho?
brendankenny
approved these changes
Sep 7, 2018
There was a problem hiding this comment.
you had thoughts tho?
I was mistaken. I thought folks were seeing the 0 ms results outside of "Passed audits", which means something weird was going on with scoring that we had to figure out.
Looks like it was just confusing people while within the passed audits section, so the fix looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For preconnect and preload audit potential savings of 0ms should not show
improve user experience
Dont show unncessary info
Related Issues/PRs
#5956