Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(asset-saver): stop creating screenshot files during --save-assets #6066

Merged
merged 3 commits into from
Sep 24, 2018
Merged

core(asset-saver): stop creating screenshot files during --save-assets #6066

merged 3 commits into from
Sep 24, 2018

Conversation

paulirish
Copy link
Member

No description provided.

brendankenny
brendankenny approved these changes Sep 20, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 📷

Should also remove *.screenshots.html/.json from package.json, .gitignore, .npmignore, and the readme :):)

patrickhulce
patrickhulce approved these changes Sep 21, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@paulirish
Copy link
Member Author

land when green.

@patrickhulce
Copy link
Collaborator

Something is still off with my permissions it seems

image

I promise I've accepted all the invitations I have! :)

@paulirish
Copy link
Member Author

@patrickhulce i think i just sorted that out. try again?

image

@patrickhulce
Copy link
Collaborator

patrickhulce commented Sep 23, 2018 •
edited
Loading

nope still blocked :/

image

hmmm, maybe GitHub hasn't matched their UI to real git permissions?

@brendankenny brendankenny merged commit ce96d76 into master Sep 24, 2018
@brendankenny brendankenny deleted the nomorescreenshtos branch September 24, 2018 22:21
@paulirish paulirish mentioned this pull request Oct 15, 2018
Closed
@csabapalfi csabapalfi mentioned this pull request Apr 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulirish @patrickhulce @brendankenny