core: stricter LR desktop metric thresholds #6969
Conversation
| @@ -137,7 +137,6 @@ function getFlags(manualArgv) { | |||
| // default values | |||
| .default('chrome-flags', '') | |||
| .default('output', ['html']) | |||
| .default('emulated-form-factor', 'mobile') | |||
There was a problem hiding this comment.
This was an erroneous double default that makes it impossible to run lr-desktop-config from the CLI
There was a problem hiding this comment.
was the cli flag winning over the config setting? Yeah, that seems bad...
There was a problem hiding this comment.
does output have the same problem? I don't see any other of these defaults in SharedFlagsSettings
Co-Authored-By: patrickhulce <patrick.hulce@gmail.com>
There was a problem hiding this comment.
I have no opinion on the new curves, so LGTM! :)
(probably at least @paulirish should take an actual look at them)
| @@ -137,7 +137,6 @@ function getFlags(manualArgv) { | |||
| // default values | |||
| .default('chrome-flags', '') | |||
| .default('output', ['html']) | |||
| .default('emulated-form-factor', 'mobile') | |||
There was a problem hiding this comment.
was the cli flag winning over the config setting? Yeah, that seems bad...
| @@ -137,7 +137,6 @@ function getFlags(manualArgv) { | |||
| // default values | |||
| .default('chrome-flags', '') | |||
| .default('output', ['html']) | |||
| .default('emulated-form-factor', 'mobile') | |||
There was a problem hiding this comment.
does output have the same problem? I don't see any other of these defaults in SharedFlagsSettings
| // 75th and 95th percentiles -> median and PODR | ||
| // SELECT QUANTILES(fullyLoaded, 21) FROM [httparchive:summary_pages.2018_12_15_desktop] LIMIT 1000 | ||
| {path: 'metrics/interactive', options: {scorePODR: 2000, scoreMedian: 4500}}, | ||
| {path: 'metrics/first-cpu-idle', options: {scorePODR: 2000, scoreMedian: 4500}}, |
There was a problem hiding this comment.
wooooo good luck desktop sites!
|
How do I downvote a review? |
|
ok, no clue what's going on with github. Merged in 161519a, PR isn't closing, so closing it manually :) |
Summary
Uses data from HTTPArchive desktop runs to get new score thresholds
CNN Before
CNN After
Related Issues/PRs
fixes #6836