core(logging): change log messages for gathering and trace retrieval

[connorjclark]

Looked back at the blame, was interested to see if these steps were named differently before.

Evaluating: https://github.com/GoogleChrome/lighthouse/blame/558a26f8661565caebcbba085b26bf028a89c283/lighthouse-core/runner.js#L94

Retrieving: https://github.com/GoogleChrome/lighthouse/blame/2a4d99c93794b883c70acbe24c332aa658e3a455/lighthouse-core/gather/gather-runner.js#L149

The answer is no :)

[brendankenny]

b914ea1

lol, commit to master of the opposite of this PR :P

[connorjclark]

b914ea1

lol, commit to master of the opposite of this PR :P

ooo guess i messed up the blame hunting

[patrickhulce]

core(misc):

I believe that's what just misc: is for, no? 😆 more on this below though...

I have some faint memory of someone using the text of the status log messages to provide significant functionality (might have been DevTools progress bar? 😬) so this might be more breaking than we think.

Buuuuuut that's probably a bad idea for whoever that was to be doing that, so I'm on board :)

Maybe we can just call it out a bit more in release notes? core(logging): change log messages for gathering and trace retrieval or something?

[patrickhulce]

I have some faint memory of someone using the text of the status log messages to provide significant functionality

(Also, the fact that in our docs we tell users to programmatically do something based on a particular log message isn't a great sign for its non-breakingness)

[brendankenny]

I have some faint memory of someone using the text of the status log messages to provide significant functionality (might have been DevTools progress bar? 😬) so this might be more breaking than we think.

This might already be picked up on the devtools side, but if not, pretty sure @patrickhulce is right on this. e.g.

https://github.com/ChromeDevTools/devtools-frontend/blob/072e6f877f246a9a10b98891d2f75c473dfa2a04/front_end/audits2/Audits2StatusView.js#L265-L286

https://cs.chromium.org/chromium/src/third_party/blink/web_tests/http/tests/devtools/audits2/audits2-successful-run-expected.txt

etc

[patrickhulce]

Unrelated beautiful gem over in "expected" results.

main-thread-tasks: ERROR Something went wrong with recording the trace over your page load. Please run Lighthouse again. (NO_FCP)

https://cs.chromium.org/chromium/src/third_party/blink/web_tests/http/tests/devtools/audits2/audits2-successful-run-expected.txt?l=340

[connorjclark]

Unrelated beautiful gem over in "expected" results.

main-thread-tasks: ERROR Something went wrong with recording the trace over your page load. Please run Lighthouse again. (NO_FCP)

cs.chromium.org/chromium/src/third_party/blink/web_tests/http/tests/devtools/audits2/audits2-successful-run-expected.txt?l=340

Ah, that settles it. We expect NO_FCP. Let's close all future NO_FCP issues as WAI :)