proto: update import hooks, obey line length #9595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Aug 22, 2019
brendankenny
approved these changes
Aug 22, 2019
| import "google/protobuf/struct.proto"; | ||
| import "google/protobuf/timestamp.proto"; | ||
| import "google/protobuf/wrappers.proto"; | ||
|
|
||
| // This comment required for LightRider import compatibility | ||
| // This comment required for LightRider import compatibility # suffix |
brendankenny
changed the title
patrickhulce
approved these changes
Aug 22, 2019
| @@ -142,7 +144,8 @@ message LighthouseResult { | |||
| // nullable list of strings | |||
| google.protobuf.Value only_categories = 3; | |||
|
|
|||
| // How Lighthouse was run, e.g. from the Chrome extension or from the npm module | |||
| // How Lighthouse was run, e.g. from the Chrome extension or from the npm | |||
| // module | |||
| @@ -154,8 +157,8 @@ message LighthouseResult { | |||
|
|
|||
| // Message containing the performance timing data for the Lighthouse run | |||
| message Timing { | |||
|
|
|||
| // Corresponds to: https://www.w3.org/TR/performance-timeline-2/#dom-performanceentry | |||
| // Corresponds to: | |||
There was a problem hiding this comment.
heavy heavy heavy sigh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are new, more strict proto linters now. These hooks allow us to import easier. And enforce the 80 char limit on our file here.