Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo.arcade.software to the whitelist #830

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

rmanalan
Copy link
Contributor

@rmanalan rmanalan commented Apr 18, 2023

Just adding demo.arcade.software to the iframe whitelist. Arcades are interactive guides that can be embedded into documentation sites. Helpful for instructing users how to do something inside a product. I've signed the CLA.

@rmanalan
Copy link
Contributor Author

@mco-gh sorry to mention you directly on this PR, but I'm not sure how PRs are triaged in this repo. Mind reviewing when you get a chance? Thanks! 🙏🏽

@mco-gh mco-gh merged commit 8b5107f into googlecodelabs:main Apr 18, 2023
@mco-gh
Copy link
Contributor

mco-gh commented Apr 18, 2023 via email

@pballai
Copy link

pballai commented May 4, 2023

I tested this and it does not work on my local site. I believe that CORS is blocking it. Which codelabs file allows me to over-ride this? Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants