-
Notifications
You must be signed in to change notification settings - Fork 249
Adds bash script for build/test of the DataLab NodeJS backend #140
Conversation
…ckend. Adds one-time global installation of jasmine-node test runner
####### CONFIG ######## | ||
# Create all of the output paths | ||
build_root="$REPO_DIR/build/server"; | ||
# TODO(bryantd): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming there is still something to do here, a short 1-liner description would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, added now
…specification in the TypeScript module system
|
||
### BUILD | ||
echo 'Building DataLab server backend...'; | ||
# Copy node .ts files to staging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be simplified by referring to specific .ts files explictly instead of first copying them to a staging location and later removing them?
The typescript compiler accepts a build file (see the @<file> option) where you could list all the args and have an explicit list of files. Sort of like a build file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to avoid maintaining an explicit build file list if possible for now as it doesn't resolve the need to fix up relative paths when building, and the dynamically generated file list via the find
operation is fast.
We could write a script which generates this build file on-demand from the source tree if we end up needing something the build file buys us down the road (and don't want to maintain the file list manually).
62909b2
to
46b44ac
Compare
Added some TODOs and corresponding issues (#141 and #142) to track them. My hope is that improvements in the TypeScript compiler that are being actively discussed will avoid us needing to fix these issues ourselves. Specifically referring to the requirejs-style path config feature: microsoft/TypeScript#293 We can probably eliminate the staging bit altogether if the path config support is added to tsc and also simplify how the tests are compiled by setting up a path in that config to the already built src/* files. |
Looks good... I'll look at getting rid of gradle completely. |
…-bash Adds bash script for build/test of the DataLab NodeJS backend
Replacements for the Gradle build system functionality