Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Remove some unused dependencies + Add some others #122

Merged
merged 4 commits into from
Jan 12, 2017
Merged

Remove some unused dependencies + Add some others #122

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8f14ab
Remove scikit-learn and scipy as dependencies
eyadsibai Jan 11, 2017
7a3cac7
add more required packages
eyadsibai Jan 11, 2017
d072b01
Add psutil as dependency
eyadsibai Jan 11, 2017
ffd77d4
Update packages versions
eyadsibai Jan 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,18 @@
'future==0.15.2',
'futures==3.0.5',
'google-cloud==0.19.0',
'google-api-python-client==1.5.1',
'seaborn==0.7.0',
'plotly==1.12.5',
'httplib2==0.9.2',
'oauth2client==2.2.0',
'psutil==4.3.0',
'pandas>=0.17.1',
'pandas-profiling>=1.0.0a2',
'python-dateutil==2.5.0',
Copy link
Contributor

@ojarjur ojarjur Jan 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two are not directly used by our code, but I think that we've included them because we want any of our users to be able to use them out of the box.

@chmeyers and @qimingj might know better about that, though.

Copy link
Contributor

@yelsayd yelsayd Jan 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case I think it should be part of Datalab (and it is) but not pydatalab right?

Copy link
Contributor

@qimingj qimingj Jan 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. They are included for user's convenience. You don't want users to install them every time they start Datalab.
Maybe we don't need to put the same list twice in docker and setup.py? Installation of pydatalab will install these anyway. That way we leave only the packages that are not listed in setup.py.

Copy link
Contributor

@yelsayd yelsayd Jan 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all related to datalab though, pydatalab shouldn't be related to that convenience.

'pytz>=2015.4',
'pyyaml==3.11',
'requests==2.9.1',
'scipy==0.18.0',
'scikit-learn==0.17.1',
'ipykernel==4.4.1',
],
package_data={
Expand Down