This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Fix a bug where an unbounded number of credentials wrappers got added. #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #1251, where the fact that we were sharing a single `httplib2.Http` instance caused each request to add an additional credentials wrapper around that single instance. That, in turn, caused a `RuntimeError: maximum recursion depth ...` error message once too many API calls had been made.
chmeyers
approved these changes
Mar 8, 2017
|
It might be cleaner to revert #195 instead of using |
parthea
approved these changes
Mar 8, 2017
There was a problem hiding this comment.
Issue googledatalab/datalab#1251 is resolved with this PR. Thanks @ojarjur!
I understand that google.datalab is part of GA. I'm still using the original datalab library. Could we also patch the _http.py file in the original datalab library at
https://github.com/googledatalab/pydatalab/blob/master/datalab/utils/_http.py?
ojarjur
force-pushed
the
ojarjur/fix-credentials-wrapping
branch
from
c413fc9 to
732f5dd
Compare
|
@parthea That's a fair point. I added the fix to the older library too. |
chmeyers
approved these changes
Mar 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the fact that we were sharing a single
httplib2.Httpinstance caused each request to add an additionalcredentials wrapper around that single instance.
That, in turn, caused a
RuntimeError: maximum recursion depth ...error message once too many API calls had been made.
This fixes googledatalab/datalab#1251