[read-fonts] avoid overflow in midpoint computation #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
reviewed
Dec 10, 2024
read-fonts/src/tables/glyf.rs
Outdated
| // Original overflowing code was: (a + b) / 2 | ||
| // Choose wrapping arithmetic here because we shouldn't ever | ||
| // hit this outside of fuzzing or broken fonts _and_ this is | ||
| // called from very performance sensitive code |
There was a problem hiding this comment.
This is a good comment. It would be great if it said what specific performance sensitive code.
rsheeter
approved these changes
Dec 10, 2024
dfrg
added a commit
that referenced
this pull request
Dec 12, 2024
dfrg
added a commit
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1279
ref https://issues.oss-fuzz.com/issues/382732980