[read-fonts] Add 'get' method to coverage tables #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ooh, looks like we have a new rustc/clippy. Also I'm wondering if this shouldn't return |
dfrg
approved these changes
Oct 6, 2023
anthrotype
approved these changes
Oct 6, 2023
I wanted this for testing the table splitting in Mark2Base, and it's something we will want anyway. This also fixes a little mixup in the signature of CoverageTable::iter; the elided lifetime here meant the compiler tied the iterator to the lifetime of the table object, whereas we really want to tie it to the lifetime of the underlying data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted this for testing the table splitting in Mark2Base, and it's something we will want anyway.
This also fixes a little mixup in the signature of CoverageTable::iter; the elided lifetime here meant the compiler tied the iterator to the lifetime of the table object, whereas we really want to tie it to the lifetime of the underlying data.
JMM