3.2.0 autohinting logic still not right?

[simoncozens]

@marekjez86 reports that in 3.2.0, fontmake is now producing autohinted fonts by default, while 3.1.3 does not. I'm having trouble reproducing, but there it is.

[marekjez86]

command that I use
fontmake -g <source> -i -o otf ttf OR fontmake -m <source> -i -o otf ttf

for any of the following sources

https://github.com/googlefonts/noto-source/tree/main/src/NotoSansGeorgian/*.designspace
https://github.com/googlefonts/noto-source/tree/main/src/NotoSerifGeorgian*.designspace

https://github.com/googlefonts/noto-source/blob/main/src/NotoSansBalinese.glyphs
https://github.com/googlefonts/noto-source/blob/main/src/NotoSansTaiTham.glyphs
https://github.com/googlefonts/noto-source/blob/main/src/NotoSerifOriya.glyphs

Note that it produces autohinted/instance_ttf by default (there's NO instance_otf in autohinted)

[marekjez86]

My favorite options would be to produce 1. unhinted only (overriding the source) 2. hinted only (also overriding the source) or 3. BOTH :-) [because I need both] ... Note that I have lived so far with 1. (unhinted only) because I use ttfautohint when I need to publish hinted versions

[anthrotype]

I believe this is a feature, not a bug, added with #850

basically if the font has a TTFAutohtint options custom parameter, fontmake will use that with ttfautohint.

All the sources that @marekjez86 linked above contain that custom parameter so they will produce autohinted fonts.

Maybe we need an additional option to skip autohinting no matter the presence of TTFAutohtint options custom parameter in the source.

[anthrotype]

@marekjez86 I added a --no-autohint option that disables ttfautohint, overriding the custom parameter