Don't save master/instance ufos by default unless -o ufo is requested #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should considerably speed up build time as we can now avoid serializing UFOs and build either VFs or static instances directly from in-memory objects. A few places that assumed things were read from/written to filesystem had to be tweaked, but the normal behaviour is unchanged. To save the UFOs you now have to explicitly include 'ufo' in the list of output formats. And if the *only* output is -o ufo, then one can also use the --output-dir option (works for either masters or instances) or even the --output-path option when selecting to build one specific instance UFO.
…ed or not It would be weird if one cares to pass that option explicitly and not get any designspace file saved.
khaledhosny
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we dropped MutatorMath support (which required to read sources from disk, #1019) we can directly build VFs or static instances from in-memory designspace + UFO objects as returned from glyphsLib or generated by fontmake.instantiator. This should considerably speed up build time as we can avoid spending time serializing UFOs.
A few places that assumed things were read from/written to the filesystem had to be tweaked, however the normal behaviour is unchanged.
Except that now, in order to actually save the designspace or UFOs, one has to explicitly include 'ufo' in the list of output formats in
-ooption.And when the only output is
-o ufo, then one can also use the--output-diroption (works for either masters or instances) or even the--output-pathoption when selecting to build one specific instance UFO.