update to use current ufo2ft API #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it already reads that from the font
also, add support for `cff_round_tolerance` (the argument is called simply `roundTolerance` in ufo2ft.compileOTF but we want to distinguish it from the other one here called round_instances). TODO: we probably need to make the ufo2ft filters/compiler/etc. logging print more info messages as it's now doing all the work.
…d 'convert_curves' Here i'm being overly picky to send out a deprecation warning, since we don't really support running fontmake.font_project as a library, but just 'fontmake' as the command-line tool.
anthrotype
commented
Jun 6, 2018
|
|
||
| if use_production_names is None: | ||
| use_production_names = not ufo.lib.get( | ||
| GLYPHS_PREFIX + "Don't use Production Names") |
There was a problem hiding this comment.
This Glyphs.app-specific UFO lib key will also be supported in the upcoming ufo2ft
googlefonts/ufo2ft@2ca438c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decomposing glyphs, removing overlaps, converting curves to quadratic can be done by appropriate ufo2ft preprocessor filters, fontmake only needs to pass the right options to the top-level compile functions.
Note that this was already implemented in the current stable ufo2ft 1.1.0 released in december last year, we just didn't update fontmake to make use of them.
Also, adds support for
cff_round_tolerance. In ufo2ft the argument is called simplyroundTolerancebut here we need to distinguish it from the other one calledround_instances.