Copy font info attributes from default font to instance selectively #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I overlooked that ufoProcessor does the same. Several attributes are actually specific to instances and should not be blindly inherited from the default font. The ignore list is different from ufoProcessor. We additionally ignore: - openTypeNameUniqueID - openTypeNameWWSFamilyName - openTypeNameWWSSubfamilyName - openTypeOS2Panose We copy over: - familyName - woffMajorVersion - woffMetadataCopyright - woffMetadataCredits - woffMetadataDescription - woffMetadataExtensions - woffMetadataLicense - woffMetadataLicensee - woffMetadataTrademark - woffMetadataVendor - woffMinorVersion This implies that the styleName attribute is now implicitly required. Not specifying it in the Designspace means it will not be set in the instance.
belluzj
approved these changes
Sep 9, 2019
|
Hm. I'll add a warning if |
anthrotype
approved these changes
Sep 9, 2019
madig
force-pushed
the
instantiator-copy-attrs-selectively
branch
from
dfc2579
to
deb9cdd
Compare
madig
force-pushed
the
instantiator-copy-attrs-selectively
branch
from
deb9cdd
to
1540244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #574.
I overlooked that ufoProcessor does the same. Several attributes are actually specific to instances and should not be blindly inherited from the default font.
The ignore list is different from ufoProcessor. We additionally ignore:
We copy over:
This implies that the styleName attribute is now implicitly required. Not specifying it in the Designspace means it will not be set in the instance.