-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility checker #832
Add compatibility checker #832
Conversation
Thanks Simon, this is super useful!! Mind adding a few tests as well? |
Will do, just as soon as I've got the ones we already have passing... |
All ready! |
This reverts commit 6ee506f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the patience!
maybe squash before you merge |
Thanks for your patience! |
We have a lot of new issues with this compatibility checker that seem to be bugs in here. |
ah sorry! it was actual compatibility problems in our UFO sources! hard to spot but real issues |
I have a problem with it, though - it's doing compatibility checks on non-exported glyphs, and it doesn't matter if they aren't compatible. |
It seems it also complains about anchor order, say "top, bottom" vs. "bottom, top". Shouldn't a case like that "just work"? Or are there cases where the anchor order is meaningful? |
No, that should just work. I'll sort it. |
Currently for Radio Canada Italic, fontmake produces this output:
This is particularly confusing because earlier on in the log it says:
So why can't it find the base master? Not an easy question for users to answer. With this PR, fontmake says:
The checker is applied when producing variable fonts or whether the Glyphs "Enforce Compatibility Check" custom parameter is turned on.