-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for UFOZ as input format when no -u flag is used #900
Conversation
`ufoLib2` will save with the same structure as it is opened. Since past UFOs are generated as `.ufo` folders, temporarily add parameter `structure="package"` to guarantee backwards compatibility. Might need to provide option to save as `.ufoz` in future updates.
thank you! I thought it was already supported, but it seems like it wasn't :) |
Sorry, I am quite new to contributing and am not sure on how to add tests 😅 |
no worries. can you please fix the linter errors here: the autoformatter (black) is complaining about line length or something. |
out of curiosity, does it work if you run I'm still ok to accept a patch like yours, just wanted to confirm that. |
isort is now complaining about the order of imports, sorry. +import os
import sys
-import os |
Yeah, using |
Also just a suggestion, might be better to provide the option to export |
yeah, sounds good. Would you like to work on that in this same PR? |
Not really, I have no idea on how to do this... |
ok that's fine. We can keep #887 open until that's done. So this PR here only adds support for reading .ufoz when passed in to the fontmake CLI without the explicit -u flag. |
Ok thank you. |
Resolves #887 .