Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logging configuration is global, does not belong to a specific
fontmake.FontProject
instance, so it should only be done insidemain()
. This PR deprecates theverbose
andtiming
parameters to FontProject constructor and moves the logging configuration to the CLI module (fontmake.__main__
).The old parameter continue to work but a deprecation warning is issued (category is actually
UserWarning
asDeprecationWarning
proper are usually muted -- just to shout it out more louder)It also enables logging configuration for a logger named "ufo2ft.timer" (which reports timing info inside ufo2ft) which doesn't exist yet but will soon (googlefonts/ufo2ft#641)
This and fontmake's own timing logger are controlled by the fontmake
--timing
flag, independently from the--verbose LEVEL
flag which control the root logger configuration.