Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support building from glyphspackages #931

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Support building from glyphspackages #931

merged 3 commits into from
Oct 28, 2022

Conversation

simoncozens
Copy link
Contributor

This requires the next version of glyphsLib (i.e. one in which glyphsLib.load can take a path name).

anthrotype
anthrotype approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending next glyphsLib release, bonus point if you add a small test
thanks!

@simoncozens simoncozens mentioned this pull request Oct 11, 2022
Open
@anthrotype anthrotype merged commit 91c24e9 into main Oct 28, 2022
@anthrotype anthrotype mentioned this pull request Oct 28, 2022
Closed
@anthrotype anthrotype deleted the glyphspackage branch October 28, 2022 22:29
@anthrotype anthrotype mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simoncozens @anthrotype