Skip to content

Commit

Permalink
have _brace_coordinates() consistently method return a list
Browse files Browse the repository at this point in the history
it was returning a generator expression for format_version>2 or a list for format_version=2 which doesn't make any sense

#971 (comment)
  • Loading branch information
anthrotype committed Feb 2, 2024
1 parent 90f10c4 commit a944fd3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def ensure_component_has_sparse_layer(font, component, parent_layer):
tags = [axis.axisTag for axis in font.axes]
master_locations = [x.axes for x in font.masters]
_, limits = variation_model(font, master_locations)
location = tuple(parent_layer._brace_coordinates())
location = parent_layer._brace_coordinates()
default_location = get_regular_master(font).axes
normalized_location = {
axisTag: normalizeValue(
Expand Down
2 changes: 1 addition & 1 deletion Lib/glyphsLib/classes.py
Original file line number Diff line number Diff line change
Expand Up @@ -3976,7 +3976,7 @@ def _brace_coordinates(self):
return None

if self.parent.parent.format_version > 2:
return (float(v) for v in self.attributes["coordinates"]) # Glyphs 3
return [float(v) for v in self.attributes["coordinates"]] # Glyphs 3

# Glyphs 2
name = self.name
Expand Down

0 comments on commit a944fd3

Please sign in to comment.