some changes suggested by @belluzj

googlefonts · Jul 4, 2023 · c004fbb · c004fbb
1 parent c75966e
commit c004fbb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/Lib/glyphsLib/builder/builders.py b/Lib/glyphsLib/builder/builders.py
@@ -734,7 +734,6 @@ def _fake_designspace(self, ufos):
     from .masters import to_glyphs_master_attributes
     from .names import to_glyphs_family_names, to_glyphs_master_names
     from .paths import to_glyphs_paths
-    from .sources import _to_glyphs_source
     from .user_data import (
         to_glyphs_family_user_data_from_designspace,
         to_glyphs_family_user_data_from_ufo,

diff --git a/Lib/glyphsLib/builder/masters.py b/Lib/glyphsLib/builder/masters.py
@@ -50,7 +50,7 @@ def to_ufo_master_attributes(self, ufo, master):
     note = userData.get(UFO_NOTE_KEY)
     if note is not None:
         ufo.info.note = note
-        delf(userData[UFO_NOTE_KEY])
+        del(userData[UFO_NOTE_KEY])
     # All of this will go into the designspace as well
     # "Native" designspace fonts will only have the designspace info
     if master.font.formatVersion >= 3:

diff --git a/Lib/glyphsLib/classes.py b/Lib/glyphsLib/classes.py
@@ -2737,7 +2737,7 @@ def applyTransform(self, transformationMatrix):
     def draw(self, pen: AbstractPen) -> None:
         """Draws contour with the given pen."""
         pointPen = PointToSegmentPen(pen)
-        frawPoints(pointPen)
+        self.drawPoints(pointPen)
 
     def drawPoints(self, pointPen: AbstractPointPen) -> None:
         """Draws points of contour with the given point pen."""
@@ -4122,7 +4122,7 @@ class LayerComponentsProxy(LayerShapesProxy):
 
 
 class GSLayer(GSBase):
-    def _serialize_attributes_to_plist(self):
+    def _get_plist_attributes(self):
         attributes = dict(self.attributes)
         font = self.parent.parent
         if LAYER_ATTRIBUTE_AXIS_RULES in self.attributes:
@@ -4150,7 +4150,7 @@ def _serialize_to_plist(self, writer):
         if self.layerId != self.associatedMasterId:
             writer.writeObjectKeyValue(self, "associatedMasterId")
         if writer.formatVersion > 2:
-            attributes = self._serialize_attributes_to_plist()
+            attributes = self._get_plist_attributes()
             if attributes:
                 writer.writeKeyValue("attr", attributes)
         writer.writeObjectKeyValue(self, "background", self._background is not None)