Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop in GSPath.segments #621

Closed
simoncozens opened this issue Sep 22, 2020 · 1 comment
Closed

Infinite loop in GSPath.segments #621

simoncozens opened this issue Sep 22, 2020 · 1 comment

Comments

@simoncozens
Copy link
Collaborator

Glyphs paths should not start with a curve node, but sigh sometimes they do.

foo

When this happens, nodeCount is never advanced in GSPath.segments and the loop is never terminated.
@schriftgestalt
Copy link
Collaborator

This is not mandated. So this is fully supported in Glyphs.

@davelab6 davelab6 mentioned this issue Oct 18, 2020
Open
anthrotype added a commit that referenced this issue Nov 23, 2020
@anthrotype
Merge pull request #622 from simoncozens/fix-infinite-loop
e3ab911 
Fix infinite loop. Fixes #621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simoncozens @schriftgestalt