Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the OS/2 width class to map the wdth axis #451

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Conversation

belluzj
Copy link
Collaborator

@belluzj belluzj commented Oct 26, 2018

Possible improvement on the situation in googlefonts/fontmake#470

@anthrotype

@madig madig merged commit 6454fa5 into master Mar 6, 2019
@madig madig deleted the map-width-using-os2 branch March 6, 2019 10:35
@anthrotype
Copy link
Member

anthrotype commented May 7, 2019

This change shold have been discussed a bit more, or at least better documented. I only realized the effect of this now.
Basically all the noto-source variable fonts that have wdth axis have their fvar table modified by this (plus they get an additional avar SegmentMap for wdth axis, where previously avar only contained maps for wght).
Previously the wdth axis minimum in fvar was 70 (default 100 and maximum 100); now the minimum is 62.5, which is the percentage associated to "Extra Condensed" OS/2.usWidthClass (2).

I'm still not sure if I should change (and how?) the noto-source files to have them produce the same fvar/avar tables as before, or if the change is innocuous and for the good.

@anthrotype
Copy link
Member

but i looks to me like a breaking change, since anybody who was relying on the old behavior, namely that glyphsLib would not generate axis maps for wdth axis (i.e. assuming that master/instance locations for wdth axis were already in the same coordinate-space as in the fvar user-space coordinates), would now get possibly unwanted changes in the generated fvar (and avar) when building their font with glyphsLib >= 3.3.0.

@belluzj
Copy link
Collaborator Author

belluzj commented May 7, 2019

I implemented this from your comments in googlefonts/fontmake#470 (comment)

I think that your original comment still makes sense, and that the design locations and user locations should be able to be chosen independently.

@anthrotype
Copy link
Member

the design locations and user locations should be able to be chosen independently

yes, but in a way that doesn't break existing fonts

anthrotype added a commit that referenced this pull request May 9, 2019
anthrotype added a commit that referenced this pull request May 9, 2019
…ags (#519)"

This reverts commit 198c4bb.

We need to release a bugfix v3.3.1 release after reverting #451, but
this is a major new feature that changes the way fontmake --subset option
behaves. Better done if a separate release. I will re-revert it back to
master after releasing v3.3.1.
@anthrotype
Copy link
Member

reverted with 746ad75

let's continue discussing on this in #483

anthrotype added a commit to googlefonts/fontmake that referenced this pull request May 9, 2019
this is to blacklist glyphsLib 3.3.0, which changed the way width axis coordinates are interpreted (and thus the generated fvar and avar tables in variable fonts). glyphsLib v3.3.1 restores the previous behavior until we reach agreement in googlefonts/glyphsLib#483.
The change in question is googlefonts/glyphsLib#451
anthrotype added a commit that referenced this pull request May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants