Use Proxy for GSFont.features/featurePrefixes #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches Glyphs App API and for consistency with the rather identical GSFont.classes. Fixes also what seems to be a typo in test_write_font_attributes() that was writing (I think) invalid data to the file.
|
Out of curiosity, is there something that didn't work before but does with this PR? |
Without this PR they are simple lists, so you can’t access them by name, like in the examples in https://docu.glyphsapp.com/#GSFont.features. I was merging two fonts and trying to merge |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches Glyphs App API and for consistency with the rather identical GSFont.classes.