Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ufo2glyphs: preserve DS axis order #649

Merged
merged 2 commits into from
Dec 7, 2020
Merged

ufo2glyphs: preserve DS axis order #649

merged 2 commits into from
Dec 7, 2020

Conversation

madig
Copy link
Collaborator

@madig madig commented Dec 7, 2020

Previously, wght and wdth would be forcibly be made first.

@madig
ufo2glyphs: preserve DS axis order
c60e3ca 
Previously, wght and wdth would be forcibly be made first.
@belluzj
Copy link
Collaborator

belluzj commented Dec 7, 2020

LGTM

anthrotype
anthrotype approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maybe add an expilicit test with only "wght" + "wdth" that asserts that we do not add the Axes custom parameter since it follows the implicit order already

@madig madig merged commit 3d20bdb into master Dec 7, 2020
@madig madig deleted the ufo2glyphs-preserve-DS-axis-order branch December 7, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madig @belluzj @anthrotype