Code

Glyphs3#923

Code

Draft

schriftgestalt wants to merge 192 commits intomaingooglefonts/glyphsLib:mainfrom Glyphs3googlefonts/glyphsLib:Glyphs3Copy head branch name to clipboard

+12,795-3,039

Commits

Commits on Dec 22, 2023

• handling of formatVersion

  Show description for 882cef2
  schriftgestalt

  committed
  882cef2

  Copy full SHA for 882cef2

• some cli options

  schriftgestalt

  committed
  f3a5f45

  Copy full SHA for f3a5f45

• use constants for hint.type

  schriftgestalt

  committed
  ad5ba51

  Copy full SHA for ad5ba51

• more compact

  schriftgestalt

  committed
  1b31a3d

  Copy full SHA for 1b31a3d

• debug

  schriftgestalt

  committed
  2d2f170

  Copy full SHA for 2d2f170

• Very rough WIP G3 support

  Show description for 3d5a882
  schriftgestalt

  committed
  3d5a882

  Copy full SHA for 3d5a882

• some changes suggested by @belluzj

  schriftgestalt

  committed
  68e3f5a

  Copy full SHA for 68e3f5a

• only write manually set name

  schriftgestalt

  committed
  a59e907

  Copy full SHA for a59e907

• merge remnants

  schriftgestalt

  committed
  ad56abe

  Copy full SHA for ad56abe

• layer type properties

  schriftgestalt

  committed
  485a516

  Copy full SHA for 485a516

• read Feature.disabled/active

  schriftgestalt

  committed
  2ab5d59

  Copy full SHA for 2ab5d59

• check .active and order of prefix and classes

  schriftgestalt

  committed
  1a3a6ae

  Copy full SHA for 1a3a6ae

• brute force way to to disable "eraseOpenCorners" filter

  schriftgestalt

  committed
  08dc209

  Copy full SHA for 08dc209

• always return a meaningful name, as Glyphs does

  schriftgestalt

  committed
  57bbee4

  Copy full SHA for 57bbee4

• add fallback

  schriftgestalt

  committed
  e5b8286

  Copy full SHA for e5b8286

• has to be implemented properly

  schriftgestalt

  committed
  19f8283

  Copy full SHA for 19f8283

• check value

  schriftgestalt

  committed
  9c51698

  Copy full SHA for 9c51698

• fix post_read for axes_values

  schriftgestalt

  committed
  8b0f2fc

  Copy full SHA for 8b0f2fc

• conversion has to be done on import

  schriftgestalt

  committed
  bf1c080

  Copy full SHA for bf1c080

• post_read is called later

  schriftgestalt

  committed
  510c785

  Copy full SHA for 510c785

• put custom parameter only were they belong

  schriftgestalt

  committed
  66ca6fd

  Copy full SHA for 66ca6fd

• user data

  schriftgestalt

  committed
  fc1cc88

  Copy full SHA for fc1cc88

• handling of stems

  schriftgestalt

  committed
  693bce2

  Copy full SHA for 693bce2

• to better know where you are

  schriftgestalt

  committed
  f551021

  Copy full SHA for f551021

• fix stems

  schriftgestalt

  committed
  bff3e9f

  Copy full SHA for bff3e9f

• loading axes

  schriftgestalt

  committed
  4eb70b1

  Copy full SHA for 4eb70b1

• som bits and pieces

  schriftgestalt

  committed
  fc34cde

  Copy full SHA for fc34cde

• simplify internal/external axis mapping

  schriftgestalt

  committed
  2fc7b46

  Copy full SHA for 2fc7b46

• missing form previous commit

  schriftgestalt

  committed
  e0a798a

  Copy full SHA for e0a798a

• simplify weight/widthClass

  schriftgestalt

  committed
  e70ac1c

  Copy full SHA for e70ac1c

• rename file

  schriftgestalt

  committed
  fa22b0b

  Copy full SHA for fa22b0b

• new API

  schriftgestalt

  committed
  5c37528

  Copy full SHA for 5c37528

• some writer_test

  schriftgestalt

  committed
  cd9aca0

  Copy full SHA for cd9aca0

• foo

  schriftgestalt

  committed
  3941c6c

  Copy full SHA for 3941c6c

• check value

  schriftgestalt

  committed
  a9f99f0

  Copy full SHA for a9f99f0

• add FontInstanceProxy

  schriftgestalt

  committed
  8b78fd1

  Copy full SHA for 8b78fd1

• use the same default value as G2

  schriftgestalt

  committed
  5e3d94a

  Copy full SHA for 5e3d94a

• small changes and formatting

  schriftgestalt

  committed
  50d71ff

  Copy full SHA for 50d71ff

• hide Cocoa classes

  schriftgestalt

  committed
  1efb2f5

  Copy full SHA for 1efb2f5

• blue values

  schriftgestalt

  committed
  d66fcd2

  Copy full SHA for d66fcd2

• _bracket_info

  schriftgestalt

  committed
  f4c3bcf

  Copy full SHA for f4c3bcf

• default_user_loc

  schriftgestalt

  committed
  cd9f607

  Copy full SHA for cd9f607

• WIP properties API

  schriftgestalt

  committed
  6370781

  Copy full SHA for 6370781

• update test files

  schriftgestalt

  committed
  fbfd659

  Copy full SHA for fbfd659

• set the value directly

  schriftgestalt

  committed
  c061cce

  Copy full SHA for c061cce

• new lib key

  schriftgestalt

  committed
  db97dae

  Copy full SHA for db97dae

• update API

  schriftgestalt

  committed
  b3436ed

  Copy full SHA for b3436ed

• handling axis

  schriftgestalt

  committed
  eaac53b

  Copy full SHA for eaac53b

• disable test

  schriftgestalt

  committed
  f516495

  Copy full SHA for f516495

• missing import

  schriftgestalt

  committed
  0ab37ab

  Copy full SHA for 0ab37ab

• return the value as the method name suggests

  schriftgestalt

  committed
  ce38082

  Copy full SHA for ce38082

• catch if those names are not present

  schriftgestalt

  committed
  cfb0027

  Copy full SHA for cfb0027

• default values

  schriftgestalt

  committed
  a9ac37c

  Copy full SHA for a9ac37c

• remove duplicate code

  schriftgestalt

  committed
  3a01122

  Copy full SHA for 3a01122

• handling of metrics

  schriftgestalt

  committed
  1c714d8

  Copy full SHA for 1c714d8

• alignment zones

  schriftgestalt

  committed
  75b8cc3

  Copy full SHA for 75b8cc3

• make sure to return a number

  schriftgestalt

  committed
  6a5f9c8

  Copy full SHA for 6a5f9c8

• store font.note in v2 files

  schriftgestalt

  committed
  2de2678

  Copy full SHA for 2de2678

• a new font start as v3

  schriftgestalt

  committed
  8862445

  Copy full SHA for 8862445

• better formatting

  schriftgestalt

  committed
  ccae31e

  Copy full SHA for ccae31e

• in v3, only write manually set layer names

  schriftgestalt

  committed
  16ccb45

  Copy full SHA for 16ccb45

• GSInstance.__repr__

  schriftgestalt

  committed
  73a68ec

  Copy full SHA for 73a68ec

• ignore not set coordinates

  schriftgestalt

  committed
  3a2402a

  Copy full SHA for 3a2402a

• check value

  schriftgestalt

  committed
  9bd7814

  Copy full SHA for 9bd7814

• add comments

  schriftgestalt

  committed
  cfc096e

  Copy full SHA for cfc096e

• apply source name

  schriftgestalt

  committed
  cc94c5c

  Copy full SHA for cc94c5c

• set parameter directly

  schriftgestalt

  committed
  0a4b93f

  Copy full SHA for 0a4b93f

• Variable name

  schriftgestalt

  committed
  a1efb08

  Copy full SHA for a1efb08

• hide pyobjc

  schriftgestalt

  committed
  3becfb6

  Copy full SHA for 3becfb6

• we don't need to import that

  schriftgestalt

  committed
  2bf46fa

  Copy full SHA for 2bf46fa

• userdata for guides

  schriftgestalt

  committed
  fa6e42d

  Copy full SHA for fa6e42d

• remove debug

  schriftgestalt

  committed
  8d9a316

  Copy full SHA for 8d9a316

• add some API

  schriftgestalt

  committed
  86ca336

  Copy full SHA for 86ca336

• do not regenerate the glyphs.layers dict when setting the layerId

  Show description for 2125c0f
  schriftgestalt

  committed
  2125c0f

  Copy full SHA for 2125c0f

• store properties in the userData, instead of the name

  schriftgestalt

  committed
  a7a6e77

  Copy full SHA for a7a6e77

• simpler and faster

  schriftgestalt

  committed
  41e2eb4

  Copy full SHA for 41e2eb4

• handling of custom parameters in font vs masters

  schriftgestalt

  committed
  b63e73c

  Copy full SHA for b63e73c

• performance improvements

  Show description for b0ea13f
  schriftgestalt

  committed
  b0ea13f

  Copy full SHA for b0ea13f

• TODO for layer key

  schriftgestalt

  committed
  b2cd388

  Copy full SHA for b2cd388

• we need a value for each axis

  schriftgestalt

  committed
  9e4bc3d

  Copy full SHA for 9e4bc3d

• update comment

  schriftgestalt

  committed
  3a3f634

  Copy full SHA for 3a3f634

• the list is generated just above. So that should always be the correct length

  schriftgestalt

  committed
  b98ff53

  Copy full SHA for b98ff53

• Performance

  schriftgestalt

  committed
  7cb87e1

  Copy full SHA for 7cb87e1

• we need an owner

  schriftgestalt

  committed
  84638cb

  Copy full SHA for 84638cb

• glyphs.properties > ufo

  schriftgestalt

  committed
  03434be

  Copy full SHA for 03434be

• not working here

  schriftgestalt

  committed
  5942154

  Copy full SHA for 5942154

• add __repr__

  schriftgestalt

  committed
  fd46ee0

  Copy full SHA for fd46ee0

• better API

  schriftgestalt

  committed
  124c8c3

  Copy full SHA for 124c8c3

• typo

  schriftgestalt

  committed
  4b0dbba

  Copy full SHA for 4b0dbba

• missing from prev commit

  schriftgestalt

  committed
  3e7b259

  Copy full SHA for 3e7b259

• debug

  schriftgestalt

  committed
  0e5aa0a

  Copy full SHA for 0e5aa0a

• replace open_binary() to avoid warning

  schriftgestalt

  committed
  94aa517

  Copy full SHA for 94aa517

• those are added now

  schriftgestalt

  committed
  ab9929e

  Copy full SHA for ab9929e

• Handling of custom parameters and properties

  Show description for 135a161
  schriftgestalt

  committed
  135a161

  Copy full SHA for 135a161

• disable unneeded test

  schriftgestalt

  committed
  cc63a59

  Copy full SHA for cc63a59

• store "unsupported_codepage_bits" as "bit XX" as Glyphs is doing it

  schriftgestalt

  committed
  883e8bd

  Copy full SHA for 883e8bd

• fall back to zero if value is not set

  schriftgestalt

  committed
  c6288c8

  Copy full SHA for c6288c8

• foo

  schriftgestalt

  committed
  ade46ae

  Copy full SHA for ade46ae

• update usage of lib keys

  schriftgestalt

  committed
  b51ac6e

  Copy full SHA for b51ac6e

• avoid the proxy

  schriftgestalt

  committed
  7c6fe1f

  Copy full SHA for 7c6fe1f

• sync color representation

  schriftgestalt

  committed
  9195691

  Copy full SHA for 9195691

• this is now properly implemented

  schriftgestalt

  committed
  927e0cb

  Copy full SHA for 927e0cb

• avoid writing empty userData

  schriftgestalt

  committed
  59101ce

  Copy full SHA for 59101ce

• master.name

  schriftgestalt

  committed
  837ebb5

  Copy full SHA for 837ebb5

• use new layer.attributs API

  schriftgestalt

  committed
  3d28f5b

  Copy full SHA for 3d28f5b

• disable test for old API

  schriftgestalt

  committed
  ef9da1a

  Copy full SHA for ef9da1a

• better variable names

  schriftgestalt

  committed
  2cfc9e8

  Copy full SHA for 2cfc9e8

• query the layer once

  schriftgestalt

  committed
  09f3374

  Copy full SHA for 09f3374

• actually return values (not the parameter itself)

  schriftgestalt

  committed
  60dc32f

  Copy full SHA for 60dc32f

• Import zones into metrics when set on an existing masters

  schriftgestalt

  committed
  9098c35

  Copy full SHA for 9098c35

• there can be more than one GSMetricsKeyUndefined

  schriftgestalt

  committed
  79bfe3a

  Copy full SHA for 79bfe3a

• ignore zero width zones

  schriftgestalt

  committed
  77b7904

  Copy full SHA for 77b7904

• that should be equivalent

  schriftgestalt

  committed
  ac9727a

  Copy full SHA for ac9727a

• typo

  schriftgestalt

  committed
  320f70d

  Copy full SHA for 320f70d

• refactor

  schriftgestalt

  committed
  78716c0

  Copy full SHA for 78716c0

• add comment

  schriftgestalt

  committed
  c25f1d1

  Copy full SHA for c25f1d1

• use constance as in Glyphs

  schriftgestalt

  committed
  d7c01b4

  Copy full SHA for d7c01b4

• update writer test and add G3 variants

  schriftgestalt

  committed
  2cdce28

  Copy full SHA for 2cdce28

• update more tests

  schriftgestalt

  committed
  c9be3cc

  Copy full SHA for c9be3cc

• update test files

  schriftgestalt

  committed
  11d2257

  Copy full SHA for 11d2257

• always write the name in format > 2

  schriftgestalt

  committed
  5c7ddfb

  Copy full SHA for 5c7ddfb

• glyph.unicode usually is a four to five digit string with leading zeros. so A.unicode == '0041'

  schriftgestalt

  committed
  b4a7045

  Copy full SHA for b4a7045

• ufo > glyphs displaystring

  schriftgestalt

  committed
  287c628

  Copy full SHA for 287c628

• better variable name

  schriftgestalt

  committed
  9ea6150

  Copy full SHA for 9ea6150

• glyphs > ufo stored lib

  schriftgestalt

  committed
  3f5beb8

  Copy full SHA for 3f5beb8

• localizedCopyright was never implemented

  schriftgestalt

  committed
  a21e4d9

  Copy full SHA for a21e4d9

• add --format-version option

  schriftgestalt

  committed
  8208ec7

  Copy full SHA for 8208ec7

• Handling of font.note

  schriftgestalt

  committed
  1d442d6

  Copy full SHA for 1d442d6

• actually handle format_version option

  schriftgestalt

  committed
  36ad0c4

  Copy full SHA for 36ad0c4

• ignore vertWidth == 0

  Show description for 3c15c7b
  schriftgestalt

  committed
  3c15c7b

  Copy full SHA for 3c15c7b

• only write when set

  schriftgestalt

  committed
  fe57325

  Copy full SHA for fe57325

• store some stuff in instance.lib

  schriftgestalt

  committed
  6ac91f5

  Copy full SHA for 6ac91f5

• more info/CP handling

  schriftgestalt

  committed
  f519c84

  Copy full SHA for f519c84

• cleanup

  schriftgestalt

  committed
  38371f2

  Copy full SHA for 38371f2

• always write master name

  schriftgestalt

  committed
  cb97502

  Copy full SHA for cb97502

• reorder because "ExtraLight" is the more common value and we like that to show up

  Show description for be4180a
  schriftgestalt

  committed
  be4180a

  Copy full SHA for be4180a

• more info

  schriftgestalt

  committed
  abdb17a

  Copy full SHA for abdb17a

• WIP Fix custom parameter tests (pairing with Georg)

  

  belluzj

  authored and

  schriftgestalt

  committed
  b560f53

  Copy full SHA for b560f53

• Add backport of importlib.resources for Python 3.8

  

  belluzj

  authored and

  schriftgestalt

  committed
  abe5a49

  Copy full SHA for abe5a49

• actually reverse the mapping

  schriftgestalt

  committed
  de2fe08

  Copy full SHA for de2fe08

• uniqueID is a property

  schriftgestalt

  committed
  072a0e9

  Copy full SHA for 072a0e9

• add CustomParameterProxy.keys()

  schriftgestalt

  committed
  e70a099

  Copy full SHA for e70a099

• WIP: feature test

  schriftgestalt

  committed
  6d67cc3

  Copy full SHA for 6d67cc3

• Add TODO for Georg

  

  belluzj

  authored and

  schriftgestalt

  committed
  b7ba9e6

  Copy full SHA for b7ba9e6

• WIP Look into various tests with Georg

  

  belluzj

  authored and

  schriftgestalt

  committed
  c54e673

  Copy full SHA for c54e673

• code format

  schriftgestalt

  committed
  9cdce47

  Copy full SHA for 9cdce47

• better method name

  schriftgestalt

  committed
  3b3b4a9

  Copy full SHA for 3b3b4a9

• Fix warnings

  schriftgestalt

  committed
  68f64a8

  Copy full SHA for 68f64a8

• fix key

  schriftgestalt

  committed
  3b13546

  Copy full SHA for 3b13546

• Extract apple names too

  schriftgestalt

  committed
  1821cce

  Copy full SHA for 1821cce

• why only extract feature names for automatic features

  schriftgestalt

  committed
  a59d476

  Copy full SHA for a59d476

• type annotation

  schriftgestalt

  committed
  b350244

  Copy full SHA for b350244

• we don’t need to deep copy empty list

  schriftgestalt

  committed
  88e5938

  Copy full SHA for 88e5938

• bools are written as 1/0 and not True/False

  schriftgestalt

  committed
  d8f69e9

  Copy full SHA for d8f69e9

• update tests

  schriftgestalt

  committed
  e223141

  Copy full SHA for e223141

• cleanup

  schriftgestalt

  committed
  ab1373b

  Copy full SHA for ab1373b

• massage test result

  schriftgestalt

  committed
  d69570d

  Copy full SHA for d69570d

• test file

  schriftgestalt

  committed
  ceecfa7

  Copy full SHA for ceecfa7

• disable test that is not applicable

  schriftgestalt

  committed
  9d8f274

  Copy full SHA for 9d8f274

• renamed file

  schriftgestalt

  committed
  6948ff8

  Copy full SHA for 6948ff8

• some linting

  schriftgestalt

  committed
  05f5bab

  Copy full SHA for 05f5bab

• Only make the string once

  schriftgestalt

  committed
  07339fa

  Copy full SHA for 07339fa

• a lot small stuff to get most test to pass

  Show description for 8bfd705
  schriftgestalt

  committed
  8bfd705

  Copy full SHA for 8bfd705

• more linting

  schriftgestalt

  committed
  26b71c6

  Copy full SHA for 26b71c6

• add test all custom parameters

  schriftgestalt

  committed
  c3f890c

  Copy full SHA for c3f890c

• use global postscriptNamesKey

  schriftgestalt

  committed
  af0cb86

  Copy full SHA for af0cb86

• bracket layers

  schriftgestalt

  committed
  0daf102

  Copy full SHA for 0daf102

• lint

  schriftgestalt

  committed
  c159734

  Copy full SHA for c159734

• update tests

  schriftgestalt

  committed
  7c6461f

  Copy full SHA for 7c6461f

• typo

  schriftgestalt

  committed
  f7309a2

  Copy full SHA for f7309a2

• no need for a subclass any more.

  Show description for 2c9d408
  schriftgestalt

  committed
  2c9d408

  Copy full SHA for 2c9d408

• those checks are not needed any more

  schriftgestalt

  committed
  c7485b6

  Copy full SHA for c7485b6

• the parameter needs to be there to round trip

  schriftgestalt

  committed
  d81d8bc

  Copy full SHA for d81d8bc

• not needed

  schriftgestalt

  committed
  0b60440

  Copy full SHA for 0b60440

• new API

  schriftgestalt

  committed
  e2da8d2

  Copy full SHA for e2da8d2

• add tests

  schriftgestalt

  committed
  4dac6e7

  Copy full SHA for 4dac6e7

• hide unused variables

  schriftgestalt

  committed
  817c384

  Copy full SHA for 817c384

• refactor to avoid complexity warning

  schriftgestalt

  committed
  8b1502e

  Copy full SHA for 8b1502e

• remove ignore pip8 number

  schriftgestalt

  committed
  573c816

  Copy full SHA for 573c816

• add virtual masters when reading DS with bigger axis range than defined by masters

  schriftgestalt

  committed
  8ae8c7b

  Copy full SHA for 8ae8c7b

• implement writing of .glyphspackage files

  schriftgestalt

  committed
  72069e2

  Copy full SHA for 72069e2

• finally activate black

  schriftgestalt

  committed
  0c55128

  Copy full SHA for 0c55128

• refactor extracting feature names

  Show description for 13a1080
  schriftgestalt

  committed
  13a1080

  Copy full SHA for 13a1080

• ignore test files

  schriftgestalt

  committed
  07b94e0

  Copy full SHA for 07b94e0

Commits on Dec 23, 2023

• import/export of featureNames

  Show description for 84fd86e
  schriftgestalt

  committed
  84fd86e

  Copy full SHA for 84fd86e

• more code format

  schriftgestalt

  committed
  ff6d669

  Copy full SHA for ff6d669

• most lint

  schriftgestalt

  committed
  689be3c

  Copy full SHA for 689be3c

• Write explicit form

  schriftgestalt

  committed
  87d7ef6

  Copy full SHA for 87d7ef6

• just for formatting differences

  schriftgestalt

  committed
  9b55be9

  Copy full SHA for 9b55be9

• those test are not relevant any more and add one simple new test

  schriftgestalt

  committed
  842adc3

  Copy full SHA for 842adc3

• check type

  schriftgestalt

  committed
  1d3dfbd

  Copy full SHA for 1d3dfbd

• that condition was remove in error

  schriftgestalt

  committed
  386c450

  Copy full SHA for 386c450