[anchor_propagation] fix issue adjusting mark component anchor #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In anchor_propagation.py, we have code to adjust propagated anchor position when a mark component is anchored to a specific named anchor as specified in the ComponentInfo lib key. The code indiscriminately applies the adjustment in a for loop, without checking the anchor names match the expected component anchor. I modified one of the AnchorPropagation.glyphs test file by changing the order of anchors in a mark glyph used as component in order to trigger a failure. Will follow up with a fix
anthrotype
changed the title
…chor Fixes the issue described in #975 (comment)
|
I'm not sure about the regression tests failing, if it's a good thing or not in this particular case. |
anthrotype
force-pushed
the
fix-adjust-mark-anchor
branch
from
1819e57
to
ad4d56e
Compare
|
I've inspected the regresson test and I've convinced myself that these were bugs and this fixes them |
|
@simoncozens does this change look sane to you? I'm inclined to merge |
|
I think this is correct so I'm gonna merge, but feel free to file any issues that may arise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In anchor_propagation.py, we have code (added by @yanone in #617) to adjust propagated anchor position when a mark component is anchored to a specific named anchor as specified in the ComponentInfo lib key (this can be used to specify which of the seveal ligature anchors the given component is supposed to be attached to e.g. top_1, top_2 etc).
The code indiscriminately applies the adjustment inside a for loop, without checking the anchor names match the expected component anchor.
I modified one of the AnchorPropagation.glyphs test file by changing the order of anchors in a mark glyph used as component in order to trigger a failure (anchor order is itself meaningless, it only happened to work before because the last anchor was the right one).
I will follow up with a fix