Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint configuration #34

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Fix ESLint configuration #34

merged 1 commit into from
Jan 8, 2020

Conversation

pascalw
Copy link
Contributor

@pascalw pascalw commented Jan 8, 2020

  • Use babel-eslint parser for frontend code to fix ESLint parser errors.
  • Lint Node.js code too.

* Use babel-eslint parser for frontend code to fix ESLint parser errors.
* Lint Node.js code too.
@pascalw pascalw requested a review from RoelN January 8, 2020 14:06
@pascalw
Copy link
Contributor Author

pascalw commented Jan 8, 2020

@RoelN this fixes the issue you were running into on Fraunces. While at it I noticed a few other issues with the ESLint configuration so fixed those too.

@RoelN
Copy link
Collaborator

RoelN commented Jan 8, 2020

Turns out my machine kept using a backed version of specimen-boilerplate-support. I had to purge it from my cache with yarn cache clean specimen-boilerplate-support.

Other than that, looking good! 👍

Edit: relevant

@pascalw
Copy link
Contributor Author

pascalw commented Jan 8, 2020

@RoelN I've implemented the workaround suggested on the GitHub issue for that bug, which indeed seems to work. See #35.

@pascalw pascalw merged commit c887043 into master Jan 8, 2020
@pascalw pascalw deleted the fix/eslint branch January 8, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants