Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default verticalOrigin from glyph height to hhea.ascender? #231

Closed
mashabow opened this issue Mar 12, 2018 · 3 comments · Fixed by #233
Closed

Change default verticalOrigin from glyph height to hhea.ascender? #231

mashabow opened this issue Mar 12, 2018 · 3 comments · Fixed by #233

Comments

@mashabow
Copy link
Contributor

When verticalOrigin is not set, OutlineCompiler currently uses the glyph height as a fallback value:

https://github.com/googlei18n/ufo2ft/blob/ed1c03804bfedb2cba621c61652dee6dece43ac8/Lib/ufo2ft/outlineCompiler.py#L38-L45

However, it seems more reasonable to use hhea.ascender than the glyph height. This is a very common setting especially in CJK fonts.

verticalorigin

@behdad
Copy link
Collaborator

behdad commented Mar 12, 2018

Ascender sounds wrong. I would have expected either ascender+descender. No?

@moyogo
Copy link
Collaborator

moyogo commented Mar 12, 2018

The height would be ascender+abs(descender), but for the vertical origin taking the ascender as a fallback makes sense.

@behdad
Copy link
Collaborator

behdad commented Mar 12, 2018

Right. My bad. Was thinking about vertical advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants