-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default verticalOrigin from glyph height to hhea.ascender? #231
Comments
Ascender sounds wrong. I would have expected either ascender+descender. No? |
The height would be ascender+abs(descender), but for the vertical origin taking the ascender as a fallback makes sense. |
Right. My bad. Was thinking about vertical advance. |
moyogo
added a commit
to moyogo/ufo2ft
that referenced
this issue
Mar 14, 2018
moyogo
added a commit
to moyogo/ufo2ft
that referenced
this issue
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When
verticalOrigin
is not set, OutlineCompiler currently uses the glyph height as a fallback value:https://github.com/googlei18n/ufo2ft/blob/ed1c03804bfedb2cba621c61652dee6dece43ac8/Lib/ufo2ft/outlineCompiler.py#L38-L45
However, it seems more reasonable to use
hhea.ascender
than the glyph height. This is a very common setting especially in CJK fonts.The text was updated successfully, but these errors were encountered: