Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Indic" glyph separation breaks mkmk #566

Closed
simoncozens opened this issue Dec 13, 2021 · 5 comments · Fixed by #567
Closed

"Indic" glyph separation breaks mkmk #566

simoncozens opened this issue Dec 13, 2021 · 5 comments · Fixed by #567

Comments

@simoncozens
Copy link
Contributor

In the mark feature writer, marks belonging to Indic glyphs are placed in abvm/blwm features and other marks are positioned using mark/mkmk.

However... the Sharada script (which goes through the USE and is not considered "Indic" by ufo2ft) uses the Devanagari udatta (U+0951). When a Sharada font is compiled with ufo2ft, all the Sharada mark positioning rules go into mark/mkmk and the "Indic" rules (containing udatta) go into abvm. The glyphs are separated out into Indic/non-Indic before creating these rules, and this means there is no interaction between Sharada marks and Devanagari marks; i.e. there is no way to place a udatta on a Sharada mark such as a Candrabindu.

I don't know if that's linguistically something that you might want to do, but e.g. Noto Sans Sharada allows it, positioning all marks in the mkmk feature.

I don't know how best to fix this:

  • Add USE scripts to the indicScripts list?
  • Provide a way of opting out of the abvm/blwm writer?
@anthrotype
Copy link
Member

thanks for reporting this.

Add USE scripts to the indicScripts list?

that'd be ok provided that all USE scripts are supposed to use abvm/blwm, which I honestly have no idea.

Provide a way of opting out of the abvm/blwm writer?

Maybe MarkFeatureWriter could have an option indicScripts (or abvmBlwmScripts?) that defaults to the current set, and one could set it to empty to skip the abvm/blwm generation

These are somewhat related: #565 and #565

@simoncozens
Copy link
Contributor Author

USE uses both abvm/blwm and mark/mkmk; you can choose. (See https://docs.microsoft.com/en-us/typography/script-development/use#opentype-feature-application-ii)

@simoncozens
Copy link
Contributor Author

I think you mean #522, and yes. Behdad suggests adding all the USE scripts in there. I think it's the obvious way to do it. If a script is either USE or Indic then we know abvm/blwm will be applied.

@anthrotype
Copy link
Member

yes that one. Let's add them all then

@simoncozens
Copy link
Contributor Author

I'll do a PR in a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants