Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use abvm/blwm on USE scripts and Khmer #567

Merged
merged 3 commits into from
Dec 13, 2021

Conversation

simoncozens
Copy link
Contributor

  • Add constants for list of Indic/USE scripts
  • Add USE and Khmer to abvm/blwm scripts

Fixes #566, #565, #522

Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simoncozens simoncozens merged commit 0f85d09 into googlefonts:main Dec 13, 2021
This was referenced Dec 13, 2021
# Correct as at Unicode 14.0
"Tibt", # Tibetan
"Mong", # Mongolian
# HB has Sinhala commented out here?!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because we send it to Indic. Uncomment.

@behdad
Copy link
Collaborator

behdad commented Dec 13, 2021

Make sure you handle Myanmar as well.

@simoncozens
Copy link
Contributor Author

MS suggests using mark for Myanmar, not abvm/blwm.

@behdad
Copy link
Collaborator

behdad commented Dec 13, 2021

MS suggests using mark for Myanmar, not abvm/blwm.

Right.

@khaledhosny
Copy link
Collaborator

With this PR, my kashida mark to base is moved from mark feature to abvm/blwm and they don’t get applied for Arabic except in HarfBuzz.

@khaledhosny
Copy link
Collaborator

I guess this is because unicodedata.script_extension() returns {'Phlp', 'Arab', 'Mand', 'Ougr', 'Syrc', 'Mani', 'Sogd', 'Adlm', 'Rohg'} for 0x0640, but:

  1. For characters that can b e used in multiple scripts, it should be added to all relevant features for these scripts, not only one of them.
  2. If the font does not have any characters of a given script other than shared ones, it should not be considered (alternatively font’s languagesystems should to be consulted).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Indic" glyph separation breaks mkmk
4 participants