Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fontTools.cu2qu on non-CPython? #632

Closed
madig opened this issue Jul 11, 2022 · 2 comments · Fixed by #756
Closed

Use fontTools.cu2qu on non-CPython? #632

madig opened this issue Jul 11, 2022 · 2 comments · Fixed by #756

Comments

@madig
Copy link
Collaborator

madig commented Jul 11, 2022

AFAIU, the separate cu2qu dependency is for building binary wheels, but Pypy is probably better off using the pure-Python code imported into fontTools directly. It will fetch the pure Python wheel regardless, but it's basically an extra depedency that isn't necessary?

@anthrotype
Copy link
Member

Yeah. I suggest we do this:

  1. change all cu2qu imports inside ufo2ft to try/except ImportError blocks that try to import standalone cu2qu first, if that's missing, use the fontTools.cu2qu.
  2. add a new cu2qu extra to ufo2ft's setup.py which installs the standalone (cython accelerated) cu2qu, and remove cu2qu from the required install_requires
  3. change fontmake to install_require a cu2qu-less ufo2ft for pypy implementations, otherwise ufo2ft[cu2qu]

@bkmgit bkmgit mentioned this issue Aug 30, 2022
@anthrotype
Copy link
Member

the next fonttools release will include binary wheels for all cpythons/platforms except pypy (where pure python works best). once that is out we can finally change the imports and drop the dependency on the standalone cu2qu (which we were using only because of the binary wheels basically).

anthrotype added a commit that referenced this issue Jun 12, 2023
now that fonttools publishes precompiled binary wheels we can just use the copy inside fontTools.cu2qu

Fixes #632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants