Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support public.fontInfo lib key for variable fonts #812

Closed
anthrotype opened this issue Jan 17, 2024 · 3 comments · Fixed by #816
Closed

Support public.fontInfo lib key for variable fonts #812

anthrotype opened this issue Jan 17, 2024 · 3 comments · Fixed by #816
Assignees
@khaledhosny

Comments

@anthrotype
Copy link
Member

As defined in fonttools/fonttools#3358
@anthrotype
Copy link
Member Author

I believe it should be sufficient that we merge the public.fontInfo dictionary with the base master UFO's fontinfo (copying the latter if inplace=False) and then proceed to build the VF as usual

@khaledhosny khaledhosny self-assigned this Jan 25, 2024
@khaledhosny
Copy link
Collaborator

I’m working on this but modifying source UFOs does not work with multiple variable-fonts as the source fonts seem to be built only once.

@khaledhosny
Copy link
Collaborator

I’m feeling this is better handled by the postProcessor after merging the source fonts. It will probably result in some duplicated code, but it seems cleaner and less error-prone.

@khaledhosny khaledhosny mentioned this issue Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khaledhosny khaledhosny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply DesignSpace variable-font's public.fontInfo lib key to variable fonts googlefonts/ufo2ft
2 participants
@khaledhosny @anthrotype