Apply DesignSpace variable-font's public.fontInfo lib key to variable fonts #816
Conversation
|
@anthrotype This is a PoC of using PostProcessor to update the compiled font. The use of OutlineCompiler is essentially a hack to avoid duplicating much logic about building tables, but I don’t like it much. Probably some duplication is OK, or may be we should go back to your initial idea, but I don’t know how to make it work for multiple variable-fonts with the current building and merging logic. |
khaledhosny
force-pushed
the
vf-fontinfo
branch
from
1664a36
to
f879bd9
Compare
|
I don't like this conceptually. We should try to see if we can maybe duplicate/make the base master unique before proceeding to compile each VFs |
argh.. I actually tried and failed, it's too complicated 😢 |
|
I'm warming up to the idea that this is best done inside the postProcessor like you're doing here. I don't like it but I dislike the alternative more |
I was trying that as well and it is indeed complicated. |
khaledhosny
force-pushed
the
vf-fontinfo
branch
2 times, most recently
from
5fd5774
to
f8a40e6
Compare
|
looking better now, thanks. Can we add some tests? |
khaledhosny
force-pushed
the
vf-fontinfo
branch
from
a1ba157
to
9a3b76c
Compare
Move InfoCompiler into its own module, move all the info update logic into it, make it explicit what attributes to merge, and handle vhea and gasp tables.
Defcon does not allow setting Font.info, and copying ufoLib2 Info does not seem to actually copy the values. The solutions here seem too convoluted, but I don’t know if there is a simpler alternative.
khaledhosny
force-pushed
the
vf-fontinfo
branch
from
9a3b76c
to
2235c37
Compare
Done. |
Fixes #812