Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outlineCompiler: round head values that may be float in UFO #155

Merged
merged 1 commit into from
Sep 8, 2017

Conversation

moyogo
Copy link
Collaborator

@moyogo moyogo commented Sep 8, 2017

No description provided.

@anthrotype anthrotype merged commit fe3befa into googlefonts:master Sep 8, 2017
@anthrotype
Copy link
Member

anthrotype commented Sep 8, 2017

@moyogo although I don't see how you're hitting floats for the head xMin, yMin, etc.
Given the way we calculate self.fontBoundingBox, i.e. as the unionRect of all the glyph's controlPointBounds, it should not be necessary to call round again.
We are already calling round inside makeGlyphsBoundingBoxes:
https://github.com/moyogo/ufo2ft/blob/a33d8851a128aa61a454bcf26ea2468aaa9500ff/Lib/ufo2ft/outlineCompiler.py#L120
I guess calling it again doesn't hurt, but I was just curious to understand.

@moyogo
Copy link
Collaborator Author

moyogo commented Sep 8, 2017

Good point, we don’t need to round the bounding box values, just the unitsPerEm.

@moyogo moyogo deleted the head-round-values branch April 17, 2018 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants