Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback for hhea caretSlopeRise and caretSlopeRun to match makeotf #177

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

punchcutter
Copy link

From googlefonts/glyphsLib#284, but do it here instead because we want to match what makeotf does, not Glyphs itself.

@anthrotype anthrotype merged commit 0404298 into googlefonts:master Nov 15, 2017
@anthrotype
Copy link
Member

thanks!

@anthrotype
Copy link
Member

anthrotype commented Nov 15, 2017

@punchcutter I made a few small adjustments like using built-in round and supporting the case where only one of the two is defined; I hope you don't mind
https://github.com/googlei18n/ufo2ft/blob/2d42d89b41538acdd89e66faa6c7c475bbea52ff/Lib/ufo2ft/fontInfoData.py#L76-L103

@punchcutter
Copy link
Author

@anthrotype I started to add non 1000 options for caretSlopeRise because the hhea spec doesn't care, but makeotf appears to always set it to 1000. It seems odd that anyone would ever manually set only the run or the rise, but this looks good to cover it all. Thanks!

@anthrotype
Copy link
Member

it is odd, and I thought about warning and ignore if one of the two was missing.. but then I thought I could just make it work.

@punchcutter
Copy link
Author

makeotf has no option to set those manually since they are always calculated from the italic angle, but more control doesn't hurt.

sladen added a commit to daltonmaag/ubuntu that referenced this pull request Jan 3, 2018
Bump requirements to require (ufo2ft==1.1.0) for hhea/iitalic angle fix on compilation
* googlefonts/ufo2ft#177
* #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants