preProcessor: load custom filters in TTFInterpolatablePreProcessor #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when we run compileInterpolatableOTFsFromDS, we already apply pre/post custom filters (that's taken care of by compileOTFs via OTFPreProcessor). However, when running compileInterpolatableTTFsFromDS, we were not applying any custom filters present in the UFO masters. Now we do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running compileInterpolatableOTFsFromDS, we were already applying any custom
filters in the UFO lib (that's taken care of by compileOTFs via OTFPreProcessor).
However, when running compileInterpolatableTTFsFromDS, we were not applying any custom filters -- now we do, although no guarantee is made as to whether those custom filters will keep interpolation-compatibility in the processed glyph sets.