Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postProcessor: clear existing “post” extraNames #360

Merged
merged 1 commit into from
Feb 6, 2020
Merged

postProcessor: clear existing “post” extraNames #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/ufo2ft/postProcessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ def _rename_glyphs_from_ufo(self):
# to TTX directly before compiling first, the post table will not
# contain the extraNames.
if "post" in otf and otf["post"].formatType == 2.0:
otf["post"].extraNames = []
anthrotype marked this conversation as resolved.
Show resolved Hide resolved
otf["post"].compile(self.otf)

if "CFF " in otf:
Expand Down
2 changes: 0 additions & 2 deletions tests/data/TestVariableFont-CFF2-useProductionNames.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,6 @@
</psNames>
<extraNames>
<!-- following are the name that are not taken from the standard Mac glyph order -->
<psName name="dotabovecomb"/>
<psName name="edotabove"/>
<psName name="uni0061"/>
<psName name="uni0065"/>
<psName name="uni0073"/>
Expand Down
2 changes: 0 additions & 2 deletions tests/data/TestVariableFont-TTF-useProductionNames.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,6 @@
</psNames>
<extraNames>
<!-- following are the name that are not taken from the standard Mac glyph order -->
<psName name="dotabovecomb"/>
<psName name="edotabove"/>
<psName name="uni0061"/>
<psName name="uni0065"/>
<psName name="uni0073"/>
Expand Down