-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass filters argument to compile funcs and PreProcessor #479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I left some comments. Also, we'd need tests for these new feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add another test in integration_test.py testing that the filters parameter is actually passed through to the preprocessor from all the compile* call sites
Good catch, some filters args were missing. |
Continues #466 and is needed for googlefonts/fontmake#737.
This also adds BaseFilter.pre to specify if the filter is a pre-filter or a post-filter. It is False, for post-filter, by default, as
loadFilter()
puts filters in postFilters by default.