Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass filters argument to compile funcs and PreProcessor #479

Merged
merged 12 commits into from
Mar 11, 2021

Conversation

moyogo
Copy link
Collaborator

@moyogo moyogo commented Mar 3, 2021

Continues #466 and is needed for googlefonts/fontmake#737.

This also adds BaseFilter.pre to specify if the filter is a pre-filter or a post-filter. It is False, for post-filter, by default, as loadFilter() puts filters in postFilters by default.

Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I left some comments. Also, we'd need tests for these new feature

Lib/ufo2ft/filters/__init__.py Outdated Show resolved Hide resolved
Lib/ufo2ft/preProcessor.py Outdated Show resolved Hide resolved
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add another test in integration_test.py testing that the filters parameter is actually passed through to the preprocessor from all the compile* call sites

tests/preProcessor_test.py Outdated Show resolved Hide resolved
@moyogo
Copy link
Collaborator Author

moyogo commented Mar 5, 2021

maybe add another test in integration_test.py testing that the filters parameter is actually passed through to the preprocessor from all the compile* call sites

Good catch, some filters args were missing.

tests/integration_test.py Outdated Show resolved Hide resolved
tests/integration_test.py Outdated Show resolved Hide resolved
@moyogo moyogo merged commit 690ad36 into googlefonts:main Mar 11, 2021
@moyogo moyogo deleted the filters-argument branch March 26, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants