Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split kerning by script, not by direction #636

Merged
merged 17 commits into from
Jul 21, 2022
Merged

Split kerning by script, not by direction #636

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c8941f6
Allow classify_glyphs to handle its classifying function returning mo…
simoncozens Jul 20, 2022
75f8a32
Allow kerning pairs to be constructed from lists of glyph names, not …
simoncozens Jul 20, 2022
1f48337
Allow access to each element of a pair
simoncozens Jul 20, 2022
ac5ddb3
Add partitionByScript method
simoncozens Jul 20, 2022
e2a0cb1
A test for the partition-pair-by-script logic
simoncozens Jul 20, 2022
f56eaf6
Split kerning by script
simoncozens Jul 19, 2022
9a5023c
Only classify glyphs into known scripts, or common if there are no sc…
simoncozens Jul 20, 2022
c236de0
Fix test expectations
simoncozens Jul 20, 2022
650498b
Flake fixes
simoncozens Jul 20, 2022
1e5a043
Fix bad feaLib AST usage
simoncozens Jul 20, 2022
f8a688c
Not my lint
simoncozens Jul 20, 2022
f8f70f9
Use constant for Zyyy
simoncozens Jul 20, 2022
4280397
Address the easy bit of the feedback
simoncozens Jul 21, 2022
33560c3
Emit the lookup references in a friendlier order
simoncozens Jul 21, 2022
69aa0a1
Fix test expectations (reordering)
simoncozens Jul 21, 2022
85003f4
Check logging of mixed script pair problems
simoncozens Jul 21, 2022
f97e791
Inheritable logger name
simoncozens Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Lib/ufo2ft/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,14 @@ def classifyGlyphs(unicodeFunc, cmap, gsub=None):
glyphSets = {}
neutralGlyphs = set()
for uv, glyphName in cmap.items():
key = unicodeFunc(uv)
if key is None:
key_or_keys = unicodeFunc(uv)
if key_or_keys is None:
neutralGlyphs.add(glyphName)
elif isinstance(key_or_keys, (list, set)):
simoncozens marked this conversation as resolved.
Show resolved Hide resolved
for key in key_or_keys:
glyphSets.setdefault(key, set()).add(glyphName)
else:
glyphSets.setdefault(key, set()).add(glyphName)
glyphSets.setdefault(key_or_keys, set()).add(glyphName)

if gsub is not None:
if neutralGlyphs:
Expand Down