Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through #636, I added typing annotations to help me understand.
I also found that the
ast
import was weird. The code uses stuff fromfeatureWriters.ast
andfeaLib.ast
as if they were from the same namespace. Maybe I'm too tired to understand.There were also some opportunities to replace
set([something])
by{someting}
.Todo: While looking at https://github.com/daltonmaag/ubuntu/tree/master/source/Ubuntu-B.ufo, I found that the
fi
glyph was considered as belonging to theZyyy
script for some reason. Weird.