Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KerningPair: add annotations #638

Merged
merged 2 commits into from
Jul 25, 2022
Merged

KerningPair: add annotations #638

merged 2 commits into from
Jul 25, 2022

Conversation

madig
Copy link
Collaborator

@madig madig commented Jul 22, 2022

While going through #636, I added typing annotations to help me understand.

I also found that the ast import was weird. The code uses stuff from featureWriters.ast and feaLib.ast as if they were from the same namespace. Maybe I'm too tired to understand.

There were also some opportunities to replace set([something]) by {someting}.

Todo: While looking at https://github.com/daltonmaag/ubuntu/tree/master/source/Ubuntu-B.ufo, I found that the fi glyph was considered as belonging to the Zyyy script for some reason. Weird.

@anthrotype
Copy link
Member

The code uses stuff from featureWriters.ast and feaLib.ast as if they were from the same namespace

yeah that was a feature, but I see how static typechecker may get confused

@anthrotype
Copy link
Member

I found that the fi glyph was considered as belonging to the Zyyy script for some reason

maybe because it's unicode is a PUA?
https://github.com/daltonmaag/ubuntu/blob/f3476dcc8690b1d9cedcad8a8f2814aa7b10fdb8/source/Ubuntu-B.ufo/glyphs/fi.glif#L3

@madig
Copy link
Collaborator Author

madig commented Jul 25, 2022

maybe because it's unicode is a PUA

Oh, that must be it. Not an issue then.

@madig madig merged commit 7d0a330 into main Jul 25, 2022
@madig madig deleted the script-splitting-add-annotations branch July 25, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants