Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Split kerning by script, not by direction (#636)" #666

Merged
merged 4 commits into from
Oct 14, 2022

Conversation

madig
Copy link
Collaborator

@madig madig commented Oct 11, 2022

This reverts commit bdac61e.

We need to test it more thoroughly first.

@anthrotype
Copy link
Member

for reference, linking below the related issues
#642
#658

@madig madig force-pushed the revert-kern-splitter branch from 2de7e50 to 09062f0 Compare October 11, 2022 09:46
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
This will enable to unblock releasing from main. We can re-revert this after release, keep it in a PR branch until we sort out those issues. Maybe we can enable it behind a flag until we are confident it doesn't break things.

@madig
Copy link
Collaborator Author

madig commented Oct 11, 2022

@simoncozens I moved your commits and mine regarding kern splitting over to #667

@anthrotype anthrotype merged commit f8f6bac into main Oct 14, 2022
@anthrotype anthrotype deleted the revert-kern-splitter branch October 14, 2022 10:28
@anthrotype anthrotype restored the revert-kern-splitter branch October 14, 2022 10:28
@khaledhosny khaledhosny deleted the revert-kern-splitter branch November 18, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants