Revert "Don't skip over spacing marks when kerning (#720)" #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 87c6881.
|
I don't agree with reverting this. #720 is helpful in the small (but real) corner case of kerning between spacing combining marks. I don't think we should revert that benefit just because it crashes in the vanishingly tiny case of spacing marks with zero width in some masters. |
|
ok.. but what would you do (or recommend users to do) as a workaround in that specific case? |
|
If they want all masters to be treated as non-spacing, set the zero-width master to have width==1 unit. |
|
let's hope this doesn't bite us later on |
|
Is this documented or warned about anywhere? |
could googlefonts/fontmake#894 (comment) be it biting us? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #720 while we find a fix for #721