allow to disable automatic setting of USE_MY_METRICS glyf component flag #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is unnecessary (no-op) for unhinted fonts, allow to disable it.
anthrotype
added a commit
to googlefonts/fontmake
that referenced
this pull request
Apr 20, 2023
anthrotype
added a commit
to googlefonts/fontmake
that referenced
this pull request
Apr 20, 2023
anthrotype
added a commit
to googlefonts/fontmake
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting USE_MY_METRICS (0x0200) the way ufo2ft does (to the component whose base glyph has the same advance width and horizontal positioning as the composite glyph as a whole) is not necessary for fonts that do not have hinted metrics
Having this flag set doesn't hurt either (it's basically no-op for unhinted fonts), thus I don't want to change the default behavior otherwise it will produce spurious diffs.
At least we allow to disable this feature. It will also help us when comparing the output of fontmake-py vs fontmake-rs (which does not implement this unnecessary USE_MY_METRICS flag setting).
(FWIW Glyphs.app also does not set this flag)