Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent recursion error with cyclical components and provide descriptive error message #813

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

anthrotype
Copy link
Member

@anthrotype anthrotype force-pushed the cyclical-components branch 3 times, most recently from e5d6e3b to 8eb224b Compare January 19, 2024 12:12
@anthrotype
Copy link
Member Author

@emmamarichal with this, you should now get a more friendly error message than a RecursionError, telling you exactly how to find the cycle:

$ fontmake ../Gelasio/master_ufo/Gelasio.designspace -o variable
INFO:fontmake.font_project:Building variable fonts variable_ttf/Gelasio-VF.ttf
INFO:ufo2ft:Features are compatible across masters; building later
INFO:ufo2ft:Pre-processing glyphs
INFO:ufo2ft.filters:Running EraseOpenCornersFilter on Gelasio-Regular
fontmake: Error: In '../Gelasio/master_ufo/Gelasio.designspace': Generating fonts from Designspace failed: cyclical component reference: Ccedilla -> cedillacomb.case -> cedilla -> cedillacomb => cedilla

@emmamarichal
Copy link

Excellent! Thank you @anthrotype!

…aversing again

and provide a better error message
@anthrotype anthrotype merged commit bb263dd into main Jan 19, 2024
9 checks passed
@anthrotype anthrotype deleted the cyclical-components branch January 19, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail when building variable font: maximum recursion depth exceeded
2 participants